Trigger parameter hints on accepting a function-like completion item #1802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
reviewed
Aug 26, 2025
| title: "Trigger Parameter Hints", | ||
| command: "editor.action.triggerParameterHints", | ||
| }, | ||
| ...item, |
There was a problem hiding this comment.
nit: I'd like to confirm an existing command should be used when one is already defined on item.
There was a problem hiding this comment.
Yeah, if we ever have a command on an item we keep that rather than overriding it with triggering signature help. This shouldn't matter as of now since SourceKit-LSP already doesn't set commands for completion items.
plemarquand
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're working on implementing signature help in SourceKit-LSP (swiftlang/sourcekit-lsp#2250) and we faced a problem in VS Code where signature help wasn't triggered after accepting a completion item for a function, method, subscript, initializer, or enum case with associated values that would've normally had signature help if the user manually typed the
(after the signature name.Here's a demo of the issue with a development version of SourceKit-LSP:
before.mp4
To fix this, we added a
provideCompletionItemmiddleware that inspects completion items that might have signature help (functions, methods (includes subscripts), initializers, and enum cases) and injects aneditor.action.triggerParameterHintscommand (if no other command was present). This results in signature help working pretty well with completion as shown in the video below.after.mp4
Tasks